flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1605] Bundle all hadoop dependencies an...
Date Tue, 10 Mar 2015 09:43:03 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/454#issuecomment-78022132
  
    Here are some points to double check
      - You exclude all the `flink-clients` web docs from the uberjar. I would guess this
breaks the webclient, because it uses the JAR file as its web root, or am I overlooking something?
      - The uberjar has the YARN session as the main class. Seems strange to make this one
the main class of the Uberjar, when there are several main classes (JobManager, TaskManager,
CliFrontend, WebClient, AppMaster, ...)
      - Previously, the shade plugin was deactivated for the quickstarts. Is that no longer
necessary?
      - Comments inline about the `asm` groupId
    
    If none of these points is actually an issue, then +1 to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message