flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1622][java-api][scala-api] add a partia...
Date Tue, 10 Mar 2015 09:01:26 GMT
Github user aljoscha commented on the pull request:

    I like the implementation, except for my comments on groupReducePartial() on grouped DataSets.
Also, the tests seem a bit shady because of all the grouping and regular reduceGroup operations.
I would suggest partitioning the data using a manual partition operation and then applying
a GroupReducePartial.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message