flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vasia <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1514][Gelly] Add a Gather-Sum-Apply ite...
Date Sun, 08 Mar 2015 20:36:45 GMT
Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/408#discussion_r26008662
  
    --- Diff: flink-staging/flink-gelly/pom.xml ---
    @@ -52,4 +52,35 @@ under the License.
     			<scope>test</scope>
     		</dependency>
     	</dependencies>
    +
    +    <!-- See main pom.xml for explanation of profiles -->
    +    <profiles>
    +        <profile>
    +            <id>hadoop-1</id>
    +            <activation>
    +                <property>
    +                    <!-- Please do not remove the 'hadoop1' comment. See ./tools/generate_specific_pom.sh
-->
    +                    <!--hadoop1--><name>hadoop.profile</name><value>1</value>
    +                </property>
    +            </activation>
    +            <dependencies>
    +                <!-- Add this here, for hadoop-2 we don't need it since we get guava
transitively -->
    +                <dependency>
    +                    <groupId>com.google.guava</groupId>
    +                    <artifactId>guava</artifactId>
    +                    <version>${guava.version}</version>
    +                    <scope>provided</scope>
    +                </dependency>
    +            </dependencies>
    +        </profile>
    +        <profile>
    --- End diff --
    
    Regarding the pom, we've actually merged this change as part of #429. We added the guava
dependency after [this discussion](https://mail-archives.apache.org/mod_mbox/flink-dev/201502.mbox/%3CCAJAsdNijOSZwqnn1ugw0qwJvXurmjb%3DOz64-sd3u97gZcbcW0Q%40mail.gmail.com%3E)
in the dev mailing list. If there's a better way to deal with this, please let me know! The
hadoop2 profile seems to be there by mistake, I'll fix that :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message