flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1514) [Gelly] Add a Gather-Sum-Apply iteration method
Date Fri, 20 Feb 2015 14:52:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328998#comment-14328998

ASF GitHub Bot commented on FLINK-1514:

Github user vasia commented on the pull request:

    Hi @balidani! Thanks a lot for this PR! Gather-Sum-Apply will be an awesome addition to
Gelly ^^
    Here come my comments:
    - There's no need for Gather, Sum and Apply functions to implement MapFunction, FlatJoinFunction,
etc., since they are wrapped inside those in GatherSumApplyIteration class. Actually, I would
use the Rich* versions instead, so that we can have access to open() and close() methods.
You can look at how `VertexCentricIteration` wraps the `VertexUpdateFunction` inside a `RichCoGroupFunction`.
    - With this small change above, we could also allow access to aggregators and broadcast
sets. This must be straight-forward to add (again look at `VertexCentricIteration` for hints).
We should also add `getName()`, `setName()`, `getParallelism()`, `setParallelism()` methods
to `GatherSumApplyIteration`.
    - Finally, it'd be great if you could add the tests you have as examples, i.e. one for
Greedy Graph Coloring and one for GSAShortestPaths.
    Let me know if you have any doubts!
    Thanks again :sunny:

> [Gelly] Add a Gather-Sum-Apply iteration method
> -----------------------------------------------
>                 Key: FLINK-1514
>                 URL: https://issues.apache.org/jira/browse/FLINK-1514
>             Project: Flink
>          Issue Type: New Feature
>          Components: Gelly
>    Affects Versions: 0.9
>            Reporter: Vasia Kalavri
>            Assignee: Daniel Bali
> This will be a method that implements the GAS computation model, but without the "scatter"
step. The phases can be mapped into the following steps inside a delta iteration:
> gather: a map on each < srcVertex, edge, trgVertex > that produces a partial value
> sum: a reduce that combines the partial values
> apply: join with vertex set to update the vertex values using the results of sum and
the previous state.

This message was sent by Atlassian JIRA

View raw message