flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1512) Add CsvReader for reading into POJOs.
Date Tue, 24 Feb 2015 09:19:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334707#comment-14334707
] 

ASF GitHub Bot commented on FLINK-1512:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/426#discussion_r25237861
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
    @@ -235,8 +252,21 @@ public OUT readRecord(OUT reuse, byte[] bytes, int offset, int numBytes)
throws
     		
     		if (parseRecord(parsedValues, bytes, offset, numBytes)) {
     			// valid parse, map values into pact record
    -			for (int i = 0; i < parsedValues.length; i++) {
    -				reuse.setField(parsedValues[i], i);
    +			if (pojoTypeInfo == null) {
    +				Tuple result = (Tuple) reuse;
    +				for (int i = 0; i < parsedValues.length; i++) {
    +					result.setField(parsedValues[i], i);
    +				}
    +			} else {
    +				for (int i = 0; i < parsedValues.length; i++) {
    +					try {
    +						pojoTypeInfo.getPojoFieldAt(i).field.set(reuse, parsedValues[i]);
    --- End diff --
    
    I'm not 100% sure if this also works for pojo's with private fields.
    In your testcase, all the fields are public. I'm not sure where exactly we are setting
the fields accessible, but it might be the case that they are not set accessible here. 
    Can you add a private field with a getter/setter to the test pojo to validate this?


> Add CsvReader for reading into POJOs.
> -------------------------------------
>
>                 Key: FLINK-1512
>                 URL: https://issues.apache.org/jira/browse/FLINK-1512
>             Project: Flink
>          Issue Type: New Feature
>          Components: Java API, Scala API
>            Reporter: Robert Metzger
>            Assignee: Chiwan Park
>            Priority: Minor
>              Labels: starter
>
> Currently, the {{CsvReader}} supports only TupleXX types. 
> It would be nice if users were also able to read into POJOs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message