flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1472] Fixed Web frontend config overvie...
Date Wed, 25 Feb 2015 19:01:52 GMT
Github user StephanEwen commented on the pull request:

    I like the idea - that means that the webfrontend now shows what values are actually used,
even if they are not in the config.
    To make it even nicer, it would be cool to:
      - Show which values come from the config (top) and show for which ones what default
is used (in a second section below)
      - add a Unit test that checks that all keys from the `ConfigConstants` are converted.
I think it is easy to check this via enumerating all fields in the class using reflection.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message