flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-785] Chained AllReduce
Date Wed, 11 Feb 2015 17:23:42 GMT
Github user zentol commented on the pull request:

    https://github.com/apache/flink/pull/370#issuecomment-73923184
  
    sorry for not making it clear that i forced pushed some changes, forgot making a separate
branch.
    
    the changes you made to the driver are already in, sorry for wasting your time there.
    i will include the changes to the test case.
    
    The ChainedAllReduceDriver currently does not cause any problems.
    I've added a ChainedAllGroupReduceCombineDriver aswell, which fails for one test case
    ```
    ReplicatingDataSourceITCase.after:69->TestBaseUtils.compareResultsByLinesInMemory:223->TestBaseUtils.compareResultsByLinesInMemory:238
arrays first differed at element [0]; expected:<([50050]0)> but was:<([37525]0)>
    ```
    may be related to FLINK-1521, once the newest test is complete I'll hopefully have a definite
answer. when i force objectReuse in the global reduce all tests pass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message