flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1396][FLINK-1303] Hadoop Input/Output d...
Date Wed, 04 Feb 2015 21:06:33 GMT
Github user fhueske commented on the pull request:

    Looks good. 
    Besides the typos and inline comments, you could also move the `HadoopInputFormatTest`
and the `HadoopIOFormatsITCase` to flink-java and flink-tests. 
    We could even integrate HadoopIFs even more, if we overload the "regular" Flink input
functions `ExecutionEnvironment.readFile()` and `ExecutionEnvironment.createInput()` instead
of using "special" HadoopIF functions. What do you think?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message