flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsaputra <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1442] Reduce memory consumption of arch...
Date Wed, 04 Feb 2015 16:41:58 GMT
Github user hsaputra commented on a diff in the pull request:

    https://github.com/apache/flink/pull/344#discussion_r24097257
  
    --- Diff: flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingMemoryArchivist.scala
---
    @@ -31,10 +31,11 @@ trait TestingMemoryArchivist extends ActorLogMessages {
     
       def receiveTestingMessages: Receive = {
         case RequestExecutionGraph(jobID) =>
    -      graphs.get(jobID) match {
    -        case Some(executionGraph) => sender ! ExecutionGraphFound(jobID, executionGraph)
    -        case None => sender ! ExecutionGraphNotFound(jobID)
    +      val executionGraph = getGraph(jobID)
    +      if (executionGraph != null) {
    --- End diff --
    
    I like @tillrohrmann to use Option as alternative to null. In Java land, Guava's Optional
could be use to do similar thing (which I think will be part of Java8)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message