Return-Path: 
 <issues-return-6697-apmail-flink-issues-archive=flink.apache.org@flink.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 04CAECDE5
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Mon, 26 Jan 2015 12:42:46 +0000 (UTC)
Received: (qmail 64202 invoked by uid 500); 26 Jan 2015 12:42:46 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 64154 invoked by uid 500); 26 Jan 2015 12:42:46 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 64145 invoked by uid 99); 26 Jan 2015 12:42:46 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jan 2015 12:42:46 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Mon, 26 Jan 2015 12:42:44 +0000
Received: (qmail 63390 invoked by uid 99); 26 Jan 2015 12:42:24 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jan 2015 12:42:24 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 0D24FE03F2; Mon, 26 Jan 2015 12:42:24 +0000 (UTC)
From: aljoscha <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-333-flink@git.apache.org>
In-Reply-To: <git-pr-333-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-1330] [build] Build creates a
 link in t...
Content-Type: text/plain
Message-Id: <20150126124224.0D24FE03F2@git1-us-west.apache.org>
Date: Mon, 26 Jan 2015 12:42:24 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/333#discussion_r23527422
  
    --- Diff: flink-dist/pom.xml ---
    @@ -436,6 +436,37 @@ under the License.
     					</gitDescribe>
     				</configuration>
     			</plugin>
    +
    +			<!-- create a symbolic link to the build target in the root directory -->
    +			<plugin>
    +				<groupId>com.pyx4j</groupId>
    +				<artifactId>maven-junction-plugin</artifactId>
    +				<version>1.0.3</version>
    +				<executions>
    +					<execution>
    +						<phase>package</phase>
    +						<goals>
    +							<goal>link</goal>
    +						</goals>
    +					</execution>
    +					<execution>
    +						<id>unlink</id>
    +						<phase>clean</phase>
    +						<goals>
    +							<goal>unlink</goal>
    +						</goals>
    +					</execution>
    +				</executions>
    +				<configuration>
    +					<links>
    +						<link>
    +							<dst>${basedir}/../build-target</dst>
    --- End diff --
    
    Isn't based deprecated? In the next line you use project.basedir.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---