flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1369] [types] Add support for Subclasse...
Date Fri, 16 Jan 2015 22:21:43 GMT
GitHub user fhueske opened a pull request:


    [FLINK-1369] [types] Add support for Subclasses, Interfaces, Abstract Classes

    This PR rebased PR #236 to the current master.
    Some tests were failing and I had a closer look. The original PR handled interfaces and
abstract classes without member variables as POJO types. However, POJO types without members
cannot be handled correctly and do also not have members that can be referenced as keys or
    I changed the logic such that interfaces and abstract classes without members are handled
as GenericTypes.
    I'm not so familiar with the TypeExtractor, so it would be good if someone else could
have a quick look.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink aljoscha-subclass-types

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #316
commit 8f20c0df045db820f69aa18ced8658055e131081
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Date:   2014-11-26T12:27:06Z

    [FLINK-1369] [types] Add support for Subclasses, Interfaces, Abstract Classes.
    - Abstract classes with fields are handled as POJO types.
    - Interfaces and abstract classes without fields are handled as generic types.
    This closes #236
    This closes #316


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message