flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1415) Akka cleanups
Date Mon, 26 Jan 2015 15:30:35 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291956#comment-14291956
] 

ASF GitHub Bot commented on FLINK-1415:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/319#discussion_r23537642
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotSharingGroupAssignment.java
---
    @@ -42,86 +44,82 @@
     public class SlotSharingGroupAssignment implements Serializable {
     
     	static final long serialVersionUID = 42L;
    -	
    +
     	private static final Logger LOG = Scheduler.LOG;
    -	
    +
     	private transient final Object lock = new Object();
    -	
    +
     	/** All slots currently allocated to this sharing group */
     	private final Set<SharedSlot> allSlots = new LinkedHashSet<SharedSlot>();
    -	
    +
     	/** The slots available per vertex type (jid), keyed by instance, to make them locatable
*/
     	private final Map<AbstractID, Map<Instance, List<SharedSlot>>> availableSlotsPerJid
= new LinkedHashMap<AbstractID, Map<Instance, List<SharedSlot>>>();
    -	
    -	
    +
     	// --------------------------------------------------------------------------------------------
    -	
    -	
    -	public SubSlot addNewSlotWithTask(AllocatedSlot slot, ExecutionVertex vertex) {
    -		JobVertexID id = vertex.getJobvertexId();
    -		return addNewSlotWithTask(slot, id, id);
    -	}
    -	
    -	public SubSlot addNewSlotWithTask(AllocatedSlot slot, ExecutionVertex vertex, CoLocationConstraint
constraint) {
    -		AbstractID groupId = constraint.getGroupId();
    -		return addNewSlotWithTask(slot, groupId, null);
    -	}
    -	
    -	private SubSlot addNewSlotWithTask(AllocatedSlot slot, AbstractID groupId, JobVertexID
vertexId) {
    -		
    -		final SharedSlot sharedSlot = new SharedSlot(slot, this);
    -		final Instance location = slot.getInstance();
    -		
    +
    +	public SimpleSlot addSharedSlotAndAllocateSubSlot(SharedSlot sharedSlot, Locality locality,
    +													AbstractID groupId, CoLocationConstraint constraint) {
    --- End diff --
    
    I must have fallen asleep on the space button.


> Akka cleanups
> -------------
>
>                 Key: FLINK-1415
>                 URL: https://issues.apache.org/jira/browse/FLINK-1415
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> Currently, Akka has many different timeout values. From a user perspective, it would
be helpful to deduce all different timeouts from a single timeout value. Additionally, the
user should still be able to define specific values for the different timeouts.
> Akka uses the akka.jobmanager.url config parameter to override the jobmanager address
and the port in case of a local setup. This mechanism is not safe since it is exposed to the
user. Thus, the mechanism should be replaced.
> The notifyExecutionStateChange method allows objects to access the internal state of
the TaskManager actor. This causes NullPointerExceptions when shutting down the actor. This
method should be removed to avoid accessing the internal state of an actor by another object.
> With the latest Akka changes, the TaskManager watches the JobManager in order to detect
when it died or lost the connection to the TaskManager. This behaviour should be tested.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message