flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1402) Remove extra extend Serializable in InputFormat interface
Date Wed, 14 Jan 2015 18:32:35 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277397#comment-14277397

ASF GitHub Bot commented on FLINK-1402:

Github user StephanEwen commented on the pull request:

    I think this is fine to merge.
    FYI: I sometimes repeat the `Serializable` interface in the list of superinterfaces (even
when redundant) as a form of documentation. It makes it clear upon reading the class signature
that it is expected to be serializable. So anyone extending the class is easier aware of that.

> Remove extra extend Serializable in InputFormat interface
> ---------------------------------------------------------
>                 Key: FLINK-1402
>                 URL: https://issues.apache.org/jira/browse/FLINK-1402
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Henry Saputra
>            Assignee: Henry Saputra
>            Priority: Minor
> The org.apache.flink.api.common.io.InputFormat currently defined as:
> public interface InputFormat<OT, T extends InputSplit> extends InputSplitSource<T>,
> however, InputSplitSource already extend Serializable:
> public interface InputSplitSource<T extends InputSplit> extends Serializable
> so no need for InputFormat to explicitly extend Serializable interface.

This message was sent by Atlassian JIRA

View raw message