flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1389) Allow setting custom file extensions for files created by the FileOutputFormat
Date Mon, 26 Jan 2015 10:25:34 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291656#comment-14291656
] 

ASF GitHub Bot commented on FLINK-1389:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/301#issuecomment-71440329
  
    No worries ;-) I understand that discussing such a "trivial" feature feels like a waste
of time. Unfortunately these are the features that are easy to comment on for "everybody"
;-)
    
    Anyway, I guess we could have both methods besides each other if this becomes an issue,
i.e., add your String approach as configuration option to FileInputFormat and interprete it
in the default `getDirectoryFileName()` method.
    
    For now, you got my +1 for this change. It does not change the default behavior and adds
a feature.


> Allow setting custom file extensions for files created by the FileOutputFormat
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-1389
>                 URL: https://issues.apache.org/jira/browse/FLINK-1389
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>            Priority: Minor
>
> A user requested the ability to name avro files with the "avro" extension.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message