flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1389) Allow setting custom file extensions for files created by the FileOutputFormat
Date Mon, 26 Jan 2015 09:30:34 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291612#comment-14291612
] 

ASF GitHub Bot commented on FLINK-1389:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/301#issuecomment-71433679
  
    Hmmm, using the String pattern seems to be much more comfortable for users, no?
    
    If a user wants to have the data written out with some kind of filename pattern, she needs
to implement a new IF and overwrite a method instead of simply setting a configuration parameter.
    The only thing you gain is that you can do some "fancy" arithmetics (+/- 1) with the task
number.
    Not sure if that's worth it. The former way was very elegant and clean, IMO.
    
    If you persist on the having the option to choose between 0 and 1-based indexing, I would
vote to go with the former variant and keep both parameters.


> Allow setting custom file extensions for files created by the FileOutputFormat
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-1389
>                 URL: https://issues.apache.org/jira/browse/FLINK-1389
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>            Priority: Minor
>
> A user requested the ability to name avro files with the "avro" extension.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message