flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-938] Auomatically configure the jobmana...
Date Tue, 27 Jan 2015 13:37:33 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/248#discussion_r23607471
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
    @@ -519,6 +519,12 @@ object JobManager {
               configuration.setString(ConfigConstants.FLINK_BASE_DIR_PATH_KEY, config.configDir
+ "/..")
             }
     
    +        if (GlobalConfiguration.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
    +          null) == null) {
    +          configuration.setString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
    +            InetAddress.getLocalHost.getHostName)
    +        }
    +
             val hostname = configuration.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
null)
    --- End diff --
    
    Can't we just set InetAddress.getLocalHost.getHostName as the default value here instead
of having the if block above?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message