flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1415] Akka cleanups
Date Mon, 26 Jan 2015 12:30:02 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/319#discussion_r23526836
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotSharingGroupAssignment.java
---
    @@ -42,86 +44,82 @@
     public class SlotSharingGroupAssignment implements Serializable {
     
     	static final long serialVersionUID = 42L;
    -	
    +
     	private static final Logger LOG = Scheduler.LOG;
    -	
    +
     	private transient final Object lock = new Object();
    -	
    +
     	/** All slots currently allocated to this sharing group */
     	private final Set<SharedSlot> allSlots = new LinkedHashSet<SharedSlot>();
    -	
    +
     	/** The slots available per vertex type (jid), keyed by instance, to make them locatable
*/
     	private final Map<AbstractID, Map<Instance, List<SharedSlot>>> availableSlotsPerJid
= new LinkedHashMap<AbstractID, Map<Instance, List<SharedSlot>>>();
    -	
    -	
    +
     	// --------------------------------------------------------------------------------------------
    -	
    -	
    -	public SubSlot addNewSlotWithTask(AllocatedSlot slot, ExecutionVertex vertex) {
    -		JobVertexID id = vertex.getJobvertexId();
    -		return addNewSlotWithTask(slot, id, id);
    -	}
    -	
    -	public SubSlot addNewSlotWithTask(AllocatedSlot slot, ExecutionVertex vertex, CoLocationConstraint
constraint) {
    -		AbstractID groupId = constraint.getGroupId();
    -		return addNewSlotWithTask(slot, groupId, null);
    -	}
    -	
    -	private SubSlot addNewSlotWithTask(AllocatedSlot slot, AbstractID groupId, JobVertexID
vertexId) {
    -		
    -		final SharedSlot sharedSlot = new SharedSlot(slot, this);
    -		final Instance location = slot.getInstance();
    -		
    +
    +	public SimpleSlot addSharedSlotAndAllocateSubSlot(SharedSlot sharedSlot, Locality locality,
    +													AbstractID groupId, CoLocationConstraint constraint) {
    --- End diff --
    
    indentation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message