flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1389] Allow changing the filenames of t...
Date Mon, 26 Jan 2015 09:29:49 GMT
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/301#issuecomment-71433679
  
    Hmmm, using the String pattern seems to be much more comfortable for users, no?
    
    If a user wants to have the data written out with some kind of filename pattern, she needs
to implement a new IF and overwrite a method instead of simply setting a configuration parameter.
    The only thing you gain is that you can do some "fancy" arithmetics (+/- 1) with the task
number.
    Not sure if that's worth it. The former way was very elegant and clean, IMO.
    
    If you persist on the having the option to choose between 0 and 1-based indexing, I would
vote to go with the former variant and keep both parameters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message