flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1168] Adds multi-char field delimiter s...
Date Fri, 23 Jan 2015 23:39:19 GMT
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/264#issuecomment-71285644
  
    That's a good point. I copied the code from the DelimitedInputFormat which allows to specify
the charset for the record delimiter. 
    So if we go with
    1. we should also fix the DelimitedIF to UTF-8.
    2. we need to extend the StringValue which does not support charsets.
    
    1) would be the easy fix. Charset support could be added later. Any objections with going
for 1)?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message