flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1295][FLINK-883] Allow to deploy 'job o...
Date Mon, 19 Jan 2015 16:45:36 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/292#discussion_r23171462
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/net/NetUtils.java ---
    @@ -76,7 +76,7 @@ public static InetAddress resolveAddress(InetSocketAddress jobManagerAddress)
th
     						case ADDRESS:
     							if (hasCommonPrefix(jobManagerAddress.getAddress().getAddress(), i.getAddress()))
{
     								if (tryToConnect(i, jobManagerAddress, strategy.getTimeout())) {
    -									LOG.info("Determined " + i + " as the TaskTracker's own IP address");
    +									LOG.info("Determined " + i + " as the machine's own IP address");
    --- End diff --
    
    Better to use Log.info("Determined {} as the machine's own IP address.", i). That way,
the string will only be created if the log level is info or higher.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message