flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1295][FLINK-883] Allow to deploy 'job o...
Date Mon, 19 Jan 2015 16:15:27 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/292#discussion_r23169293
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
    @@ -860,8 +910,50 @@ protected Properties getYarnProperties() throws IOException {
     		return yarnProperties;
     	}
     	
    -	protected Client getClient(CommandLine line, ClassLoader classLoader) throws IOException
{
    -		return new Client(getJobManagerAddress(line), getGlobalConfiguration(), classLoader);
    +	protected Client getClient(CommandLine line, ClassLoader classLoader, String programName)
throws IOException {
    +		String jmAddrString = getJobManagerAddressString(line);
    +		InetSocketAddress jobManagerAddress = null;
    +		if(jmAddrString.equals(YARN_DEPLOY_JOBMANAGER)) {
    +			System.out.println("YARN cluster mode detected. Switching Log4j output to console");
    +			LogManager.getRootLogger().addAppender(new ConsoleAppender(new PatternLayout(DEFAULT_LOG4J_PATTERN_LAYOUT)));
    --- End diff --
    
    Do we have to hardwire log4j into our code? That contradicts slf4j's purpose. Would be
great if we could get rid of that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message