flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1320] Add an off-heap variant of the ma...
Date Wed, 14 Jan 2015 13:47:56 GMT
Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/290#issuecomment-69917694
  
    Nice :-) Regarding the DataInputDeserializer: You are right that it is currently not used,
but I think with off-heap memory enabled the buffers will always be copied to a heap byte
array, no? That's why I mentioned it.
    
    ---
    
    Did you run the integration tests manually or did you also implement the idea of randomly
choosing on/off-heap memory for the integration tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message