Mailing-List: contact issues-help@flink.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.incubator.apache.org
Date: Tue, 16 Dec 2014 21:33:14 +0000 (UTC)
From: "Stephan Ewen (JIRA)" <jira@apache.org>
To: issues@flink.incubator.apache.org
Message-ID: <JIRA.12761720.1418640105000.37900.1418765594966@Atlassian.JIRA>
In-Reply-To: <JIRA.12761720.1418640105000@Atlassian.JIRA>
References: <JIRA.12761720.1418640105000@Atlassian.JIRA>
 <JIRA.12761720.1418640105669@arcas>
Subject: [jira] [Resolved] (FLINK-1325) Add a closure cleaner for Java
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/FLINK-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephan Ewen resolved FLINK-1325.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 0.8-incubating

Implemented in 486cc908ad24c86efe1dfe341c3e8266fe9c988d

> Add a closure cleaner for Java
> ------------------------------
>
>                 Key: FLINK-1325
>                 URL: https://issues.apache.org/jira/browse/FLINK-1325
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API
>            Reporter: Stephan Ewen
>            Assignee: Aljoscha Krettek
>             Fix For: 0.8-incubating
>
>
> The Java API could really need a simple closure cleaner.
> All functions that are implemented as anonymous subclasses hold a reference to the enclosing class, unless they are implemented as part of a static method.
> That reference (called {{this$0}}) causes serialization to fail, as it draws non serializable classes into the function, even in cases where the function makes no access to the enclosing data.
> It is possible to manually set this reference to {{null}}, using reflection, or using a debugger. Then the serialization succeeds.
> I suggest to add a closure cleaner that uses an ASM visitor over the function's code to see if there is any access to the {{this$0}} field. In case there is non, the field should be set to {{null}}.
> The problem can be reproduced with the simple program below:
> {code}
> public class Test {
>   public void runProgram() throws Exception {
>     ExecutionEnvironment env = ExecutionEnvironment .getExecutionEnvironment();
>     env.generateSequence(1, 10)
>         .map(new MapFunction<Long, Long>() {
>           public Long map(Long value) {
>             return value * 2;
>           }
>         })
>         .print();
>     env.execute();
>   }
>   public static void main(String[] args) throws Exception {
>     new Test().runProgram();
>   }
> }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)