Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 800E6F980 for ; Fri, 12 Dec 2014 16:54:45 +0000 (UTC) Received: (qmail 1494 invoked by uid 500); 12 Dec 2014 16:54:45 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 1450 invoked by uid 500); 12 Dec 2014 16:54:45 -0000 Mailing-List: contact issues-help@flink.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.incubator.apache.org Delivered-To: mailing list issues@flink.incubator.apache.org Received: (qmail 1441 invoked by uid 99); 12 Dec 2014 16:54:45 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Dec 2014 16:54:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 12 Dec 2014 16:54:23 +0000 Received: (qmail 98482 invoked by uid 99); 12 Dec 2014 16:54:21 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Dec 2014 16:54:21 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id DEB8CA29F63; Fri, 12 Dec 2014 16:54:20 +0000 (UTC) From: fhueske To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-flink pull request: [FLINK-1307] Allow input from nested... Content-Type: text/plain Message-Id: <20141212165420.DEB8CA29F63@tyr.zones.apache.org> Date: Fri, 12 Dec 2014 16:54:20 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Github user fhueske commented on the pull request: https://github.com/apache/incubator-flink/pull/260#issuecomment-66800177 Ah, OK. I got it :-) I think we need only one method to recursively enumerate files (and compute their length). Not doing the `acceptFile()` check in the `getFileStats()` call is a bug, that you could fix with this PR. Otherwise, files which will not be read are included in the size estimates for the optimizer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---