flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1168) Support multi-character field delimiters in CSVInputFormats
Date Mon, 15 Dec 2014 10:58:13 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246551#comment-14246551

ASF GitHub Bot commented on FLINK-1168:

Github user fhueske commented on the pull request:

    The question is whether we want to keep the char-delimiter in the user-facing API. 
    I would remove it in the long run to have the consistent data types for record and field
    That's why I marked the char variant as deprecated and switched all occurrences to String
as we shouldn't encourage use of deprecated methods.
    Alternatively, we could add a char variant for the record delimiter but I don't think
this would give a benefit for users.
    Btw. if we keep the char versions the PR would still change about 40 files.

> Support multi-character field delimiters in CSVInputFormats
> -----------------------------------------------------------
>                 Key: FLINK-1168
>                 URL: https://issues.apache.org/jira/browse/FLINK-1168
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 0.7.0-incubating
>            Reporter: Fabian Hueske
>            Assignee: Manu Kaul
>            Priority: Minor
>              Labels: starter
> The CSVInputFormat supports multi-char (String) line delimiters, but only single-char
(char) field delimiters.
> This issue proposes to add support for multi-char field delimiters.

This message was sent by Atlassian JIRA

View raw message