flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-986] [FLINK-25] [Distributed ...
Date Tue, 09 Dec 2014 17:52:37 GMT
Github user StephanEwen commented on the pull request:

    The `IntermediateResultPartitionManager` is not safe. To make it safe against concurrent
shutdown calls, it needs to make the check for the shutdown flag and the HashMap manipulation
atomic. Here, it means it needs a proper lock, not two individually atomic structures.
    I think it does not hurt there, as it only happens once per partition at startup and once
at cleanup time.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message