flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-1293] Add support for out-of-...
Date Mon, 01 Dec 2014 13:05:19 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/243#discussion_r21087081
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/aggregation/AggregationReduceUdf.java
---
    @@ -0,0 +1,58 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.api.java.aggregation;
    +
    +import org.apache.flink.api.common.functions.ReduceFunction;
    +import org.apache.flink.api.java.tuple.Tuple;
    +
    +/**
    + * UDF computing a list of {@link AggregationFunction}'s inside a
    + * Reducer.
    + * 
    + * @param <T> Input type of {@code reduce}.
    + */
    +public class AggregationReduceUdf<IN extends Tuple> extends AggregationUdfBase<IN>
implements ReduceFunction<IN> {
    +	private static final long serialVersionUID = 5563658873455921533L;
    +
    +	private AggregationFunction<?, ?>[] functions;
    +	
    +	public AggregationReduceUdf(AggregationFunction<?, ?>... functions) {
    +		super(functions.length);
    +		this.functions = functions;
    +	}
    +	
    +	@Override
    +	public IN reduce(IN tuple1, IN tuple2) throws Exception {
    +		IN result = createResultTuple();
    --- End diff --
    
    Create the result tuple only once (in the constructor) and reuse it in all map() invocations
to reduce instantiation and GC overhead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message