Mailing-List: contact issues-help@flink.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.incubator.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-201-incubator-flink@git.apache.org>
In-Reply-To: <git-pr-201-incubator-flink@git.apache.org>
Subject: [GitHub] incubator-flink pull request: enable CSV Reader to ignore
 invalid ...
Content-Type: text/plain
Message-Id: <20141119204859.4066B945303@tyr.zones.apache.org>
Date: Wed, 19 Nov 2014 20:48:59 +0000 (UTC)

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/201#discussion_r20606237
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java ---
    @@ -269,6 +283,21 @@ public void open(FileInputSplit split) throws IOException {
     	
     	protected boolean parseRecord(Object[] holders, byte[] bytes, int offset, int numBytes) throws ParseException {
     		
    +		if (commentPrefix != null) {
    +			//check record for comments
    --- End diff --
    
    Your logic checks for comments anywhere in a line. It would even identify comments which are contained in an escaped String. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---