Mailing-List: contact issues-help@flink.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.incubator.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-201-incubator-flink@git.apache.org>
In-Reply-To: <git-pr-201-incubator-flink@git.apache.org>
Subject: [GitHub] incubator-flink pull request: enable CSV Reader to ignore
 invalid ...
Content-Type: text/plain
Message-Id: <20141114200238.9F76A941B04@tyr.zones.apache.org>
Date: Fri, 14 Nov 2014 20:02:38 +0000 (UTC)

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/201#discussion_r20382587
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/DataSourceTask.java ---
    @@ -192,8 +192,9 @@ public void invoke() throws Exception {
     							// as long as there is data to read
     							while (!this.taskCanceled && !format.reachedEnd()) {
     								// build next pair and ship pair if it is valid
    -								if ((record = format.nextRecord(record)) != null) {
    -									output.collect(record);
    +								OT r;
    --- End diff --
    
    These modifications change Flink's behavior for any type of InputFormat, not just CSVInputFormats.
    If we want to allow to skip invalid lines, this is not the right place to add this feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---