Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3E2F6F8B0 for ; Fri, 14 Nov 2014 18:13:47 +0000 (UTC) Received: (qmail 79561 invoked by uid 500); 14 Nov 2014 18:13:47 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 79527 invoked by uid 500); 14 Nov 2014 18:13:47 -0000 Mailing-List: contact issues-help@flink.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.incubator.apache.org Delivered-To: mailing list issues@flink.incubator.apache.org Received: (qmail 79518 invoked by uid 99); 14 Nov 2014 18:13:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Nov 2014 18:13:47 +0000 X-ASF-Spam-Status: No, hits=-2000.6 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 14 Nov 2014 18:13:25 +0000 Received: (qmail 79345 invoked by uid 99); 14 Nov 2014 18:13:22 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Nov 2014 18:13:22 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 93651941702; Fri, 14 Nov 2014 18:13:22 +0000 (UTC) From: FelixNeutatz To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-flink pull request: enable CSV Reader to ignore invalid ... Content-Type: text/plain Message-Id: <20141114181322.93651941702@tyr.zones.apache.org> Date: Fri, 14 Nov 2014 18:13:22 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Github user FelixNeutatz commented on the pull request: https://github.com/apache/incubator-flink/pull/201#issuecomment-63105660 I have added one minor fix in the runtime of Flink and some tests which show that it works (CsvInputFormatTest.java). Now, the question is: What do you prefer: Either my solution which enables skipping of any invalid input (all kinds of comments, headers, invalid entries) or one special function which allows to skip certain comment structures. It's up to you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---