Return-Path: 
 <issues-return-3104-apmail-flink-issues-archive=flink.apache.org@flink.incubator.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id ABDD317B8E
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Mon,  3 Nov 2014 13:46:24 +0000 (UTC)
Received: (qmail 9177 invoked by uid 500); 3 Nov 2014 13:46:24 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 9141 invoked by uid 500); 3 Nov 2014 13:46:24 -0000
Mailing-List: contact issues-help@flink.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.incubator.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.incubator.apache.org>
List-Post: <mailto:issues@flink.incubator.apache.org>
List-Id: <issues.flink.incubator.apache.org>
Reply-To: dev@flink.incubator.apache.org
Delivered-To: mailing list issues@flink.incubator.apache.org
Received: (qmail 9132 invoked by uid 99); 3 Nov 2014 13:46:24 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Nov 2014 13:46:24 +0000
X-ASF-Spam-Status: No, hits=-2000.6 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Mon, 03 Nov 2014 13:46:02 +0000
Received: (qmail 8980 invoked by uid 99); 3 Nov 2014 13:46:00 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Nov 2014 13:46:00 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id 2F42499B48F; Mon,  3 Nov 2014 13:46:00 +0000 (UTC)
From: fpompermaier <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-172-incubator-flink@git.apache.org>
In-Reply-To: <git-pr-172-incubator-flink@git.apache.org>
Subject: [GitHub] incubator-flink pull request: Upgraded APIs: Flink (0.8) and
 HBase...
Content-Type: text/plain
Message-Id: <20141103134600.2F42499B48F@tyr.zones.apache.org>
Date: Mon,  3 Nov 2014 13:46:00 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user fpompermaier commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/172#discussion_r19732895
  
    --- Diff: flink-addons/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java ---
    @@ -310,17 +264,13 @@ public void open(TableInputSplit split) throws IOException {
     
     	@Override
     	public TableInputSplit[] createInputSplits(final int minNumSplits) throws IOException {
    +		HTable table = createTable(parameters);
     
    -		if (this.table == null) {
    -			throw new IOException("No table was provided.");
    -		}
    -
    -		final Pair<byte[][], byte[][]> keys = this.table.getStartEndKeys();
    -
    +		final Pair<byte[][], byte[][]> keys = table.getStartEndKeys();
     		if (keys == null || keys.getFirst() == null || keys.getFirst().length == 0) {
    -
     			throw new IOException("Expecting at least one region.");
     		}
    +		Scan scan = createScanner(parameters);
     		int count = 0;
     		final List<TableInputSplit> splits = new ArrayList<TableInputSplit>(keys.getFirst().length);
    --- End diff --
    
    Ok. done (in my local version)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---