flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1276) Misspelled class name SlotAvalablbilityListener.java
Date Mon, 24 Nov 2014 13:18:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222971#comment-14222971
] 

ASF GitHub Bot commented on FLINK-1276:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/227#discussion_r20788520
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/ValueTypeInfo.java
---
    @@ -131,7 +127,7 @@ public String toString() {
     	
     	// --------------------------------------------------------------------------------------------
     	
    -	static final <X extends Value> TypeInformation<X> getValueTypeInfo(Class<X>
typeClass) {
    --- End diff --
    
    The `final` modifiers in are technically redundant on such methods (as they are on private
methods). To me, they still sort of express an intent that the logic is the function is a
hard assumption that should not be easily swapped for something else. This, the modifier is
a soft documentation token...


> Misspelled class name SlotAvalablbilityListener.java
> ----------------------------------------------------
>
>                 Key: FLINK-1276
>                 URL: https://issues.apache.org/jira/browse/FLINK-1276
>             Project: Flink
>          Issue Type: Bug
>          Components: Local Runtime
>    Affects Versions: 0.8-incubating
>            Reporter: Suneel Marthi
>            Assignee: Suneel Marthi
>            Priority: Trivial
>             Fix For: 0.8-incubating
>
>
> 1. Misspelled Class name - 'SlotAvailablblityListener'.
> 2. All methods in MathUtils.java are declared as static final.
> 3. Many other minor fixes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message