flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1244) setCombinable() clunky to use
Date Sun, 16 Nov 2014 15:30:33 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213943#comment-14213943
] 

ASF GitHub Bot commented on FLINK-1244:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/incubator-flink/pull/205

    [FLINK-1244] setCombinable() returns operator

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/incubator-flink set_combine_void

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/205.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #205
    
----
commit 1ab82ba2e6707d574362db8baf63c5a4b66fdfe6
Author: zentol <s.motsu@web.de>
Date:   2014-11-16T15:28:28Z

    [FLINK-1244] setCombinable() returns operator

----


> setCombinable() clunky to use
> -----------------------------
>
>                 Key: FLINK-1244
>                 URL: https://issues.apache.org/jira/browse/FLINK-1244
>             Project: Flink
>          Issue Type: Wish
>          Components: Java API
>    Affects Versions: 0.7.0-incubating
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Trivial
>              Labels: starter
>
> Setting the combinable property for a GroupReduce manually is a bit clunky, since setCombinable()
doesn't return the operator.
> A wordcount would look like this:
> {code:java}
> GroupReduceOperator output = source
> 	.map...
> 	.groupBy(1)
> 	.reduceGroup...;
> output.setCombinable(true);
> output.print();
> {code}
> whereas this would be more convenient
> {code:java}
> source
> 	.map...
> 	.groupBy(1)
> 	.reduceGroup...
> 	.setCombinale(true)
> 	.print();
> {code}
> is there a reason for it not returning the operator?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message