flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1221) Use program source line of invocation as the default function name
Date Thu, 13 Nov 2014 09:03:34 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209510#comment-14209510
] 

ASF GitHub Bot commented on FLINK-1221:
---------------------------------------

Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/197#issuecomment-62861050
  
    Thank you for the feedback.
    I've updated the pull request. I also checked what happens if the code has been compiled
without debug symbols `-g:none`. This leads to stacks like this:
    ```
    e = java.lang.Thread.getStackTrace(Thread.java:1552)
    e = Test.a(Unknown Source)
    e = Test.main(Unknown Source)
    ```
    I think its fine to have it this way.
    @uce: Getting call location of a transformation inside the operator would be difficult
for operators that have different depths of calls (I think the Reduce operator for example
is being called from different locations with different stack sizes). Therefore, it is much
easier to get the location name as early as possible


> Use program source line of invocation  as the default function name
> -------------------------------------------------------------------
>
>                 Key: FLINK-1221
>                 URL: https://issues.apache.org/jira/browse/FLINK-1221
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>    Affects Versions: 0.8-incubating
>            Reporter: Stephan Ewen
>            Assignee: Robert Metzger
>            Priority: Minor
>             Fix For: 0.8-incubating
>
>
> Right now, the default function name is {{getClass().getName()}}.
> In many cases, this is not really very revealing. Using line in the source code where
the function is invoked is more helpful.
> This can be easily obtained by
> {code}
> Thread.getCurrentThread().getStackTrace()[0]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message