flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1221) Use program source line of invocation as the default function name
Date Wed, 12 Nov 2014 17:09:34 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208266#comment-14208266
] 

ASF GitHub Bot commented on FLINK-1221:
---------------------------------------

Github user uce commented on the pull request:

    https://github.com/apache/incubator-flink/pull/197#issuecomment-62753850
  
    I think this is a very nice idea. Looks good to me.
    
    A minor point I was thinking about was to maybe add the Utils call not in the DataSet,
but directly in the operator since we also didn't specify the name there before. Is the reason
for this the different stack traces for Java and Scala? In any case, I'm also fine with the
current solution.


> Use program source line of invocation  as the default function name
> -------------------------------------------------------------------
>
>                 Key: FLINK-1221
>                 URL: https://issues.apache.org/jira/browse/FLINK-1221
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API, Scala API
>    Affects Versions: 0.8-incubating
>            Reporter: Stephan Ewen
>            Assignee: Robert Metzger
>            Priority: Minor
>             Fix For: 0.8-incubating
>
>
> Right now, the default function name is {{getClass().getName()}}.
> In many cases, this is not really very revealing. Using line in the source code where
the function is invoked is more helpful.
> This can be easily obtained by
> {code}
> Thread.getCurrentThread().getStackTrace()[0]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message