flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1218) Don't use "new Integer". Use "Integer.valueOf" instead.
Date Wed, 05 Nov 2014 20:49:34 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14199064#comment-14199064
] 

ASF GitHub Bot commented on FLINK-1218:
---------------------------------------

GitHub user sarutak opened a pull request:

    https://github.com/apache/incubator-flink/pull/183

    [FLINK-1218] Don't use "new Integer". Use "Integer.valueOf" instead.

    There are lots of "new Integer" or something line it in the code.
    We should use valueOf to avoid wasted instance creation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarutak/incubator-flink FLINK-1218

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #183
    
----
commit eb5d4f8b77662a00ac17670d5218fcc7444ace44
Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>
Date:   2014-11-05T20:46:11Z

    Fixed wasted instance creation

----


> Don't use "new Integer". Use "Integer.valueOf" instead.
> -------------------------------------------------------
>
>                 Key: FLINK-1218
>                 URL: https://issues.apache.org/jira/browse/FLINK-1218
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 0.8-incubating
>            Reporter: Kousuke Saruta
>
> There are lots of "new Integer" or something line it in the code.
> We should use valueOf to avoid wasted instance creation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message