flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: canCreateInstance() method for type ...
Date Thu, 27 Nov 2014 10:53:41 GMT
Github user uce commented on a diff in the pull request:

    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java
    @@ -57,13 +59,16 @@ public PojoSerializer(Class<T> clazz, TypeSerializer<?>[]
fieldSerializers, Fiel
     		boolean stateful = false;
    +		boolean canCreateInstance = true;
     		for (TypeSerializer<?> ser : fieldSerializers) {
     			if (ser.isStateful()) {
    --- End diff --
    Might be better readable to have both checks in the same format, i.e. either both as branches
or both ANDing.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message