flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: enable CSV Reader to ignore invalid ...
Date Mon, 24 Nov 2014 08:57:36 GMT
Github user fhueske commented on the pull request:

    https://github.com/apache/incubator-flink/pull/201#issuecomment-64166021
  
    Why should CsvInputFormat require access to currBuffer, etc?
    
    If configured lenient, `DelimitedInputFormat.nextRecord()` calls `readLine()` and `readRecord()`
until `readRecord()` returns a non-null value (or `readLine()` is false). This way, `CsvInputFormat.readRecord()`
is called with the correct buffer, offset, and length information. In both cases of comment
and invalid lines, `CsvInputFormat.readRecord()` returns null.
    
    If not configured lenient, DelimitedInputFormat raises an exception if a null value is
returned. 
    
    Logging should still happen in CsvInputFormat, because DelimitedIF cannot distinguish
between invalid and comment lines.
    
    Would that work?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message