flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: enable CSV Reader to ignore invalid ...
Date Wed, 19 Nov 2014 20:56:11 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/201#discussion_r20606714
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
    @@ -279,6 +308,9 @@ protected boolean parseRecord(Object[] holders, byte[] bytes, int
offset, int nu
     			// check valid start position
     			if (startPos >= limit) {
     				if (lenient) {
    +					if (LOG.isWarnEnabled()) {
    --- End diff --
    
    I'd put this at least at INFO level or even at DEBUG. Logging all invalid lines can become
quite expensive.
    I'd also prefer to do this aggregated (count of invalid lines) at the end of each input
split to reduce the logging effort.
    
    Maybe you can override `open()`, call `super.open()` and log after that...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message