flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: enable CSV Reader to ignore invalid ...
Date Wed, 19 Nov 2014 20:48:59 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
    @@ -269,6 +283,21 @@ public void open(FileInputSplit split) throws IOException {
     	protected boolean parseRecord(Object[] holders, byte[] bytes, int offset, int numBytes)
throws ParseException {
    +		if (commentPrefix != null) {
    +			//check record for comments
    --- End diff --
    Your logic checks for comments anywhere in a line. It would even identify comments which
are contained in an escaped String. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message