flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-1040] Make type() call in pro...
Date Tue, 11 Nov 2014 08:23:47 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/194#discussion_r20137140
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java ---
    @@ -246,6 +247,24 @@ public ExecutionEnvironment getExecutionEnvironment() {
     		return new Projection<T>(this, fieldIndexes);
     	}
     	
    +	/**
    +	 * Initiates a Project transformation on a {@link Tuple} {@link DataSet}.<br/>
    +	 * <b>Note: Only Tuple DataSets can be projected.</b></br>
    +	 * The transformation projects each Tuple of the DataSet onto a (sub)set of fields.</br>
    +	 * This method returns a {@link ProjectOperator} to complete the transformation.
    +	 * 
    +	 * @param fieldIndexes The field indexes of the input tuples that are retained.
    +	 * 					   The order of fields in the output tuple corresponds to the order of field
indexes.
    +	 * @return A ProjectOperator to complete the Project transformation.
    +	 * 
    +	 * @see Tuple
    +	 * @see DataSet
    +	 * @see org.apache.flink.api.java.operators.ProjectOperator
    +	 */
    +	public <OUT extends Tuple> ProjectOperator<?, OUT> projection(int... fieldIndexes)
{
    --- End diff --
    
    Having ``project()`` and ``projection()`` methods might confuse users. Since this is an
evolution of the original ```project()`` method, I'd keep that name and simply remove the
``type()`` method in ``ProjectionOperator`` although this is an API breaking change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message