flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Upgraded APIs: Flink (0.8) and HBase...
Date Tue, 11 Nov 2014 08:15:21 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/172#discussion_r20136851
  
    --- Diff: flink-addons/flink-hbase/pom.xml ---
    @@ -116,20 +109,74 @@ under the License.
     			</exclusions>
     		</dependency>
     	</dependencies>
    -		<!-- <dependency>
    -			<groupId>org.apache.hbase</groupId>
    -			<artifactId>hbase-server</artifactId>
    -			<version>${hbase.version}</version>
    -		</dependency>
    -		<dependency>
    -			<groupId>org.apache.hbase</groupId>
    -			<artifactId>hbase-client</artifactId>
    -			<version>${hbase.version}</version>
    -		</dependency>
    -		 -->
     
    -	<!-- hadoop-client is available for yarn and non-yarn, so there is no need 
    -		to use profiles See ticket https://issues.apache.org/jira/browse/HADOOP-8009 
    -		for description of hadoop-clients -->
    +	<profiles>
    +		<profile>
    +			<id>hadoop-1</id>
    +			<activation>
    +				<property>
    +					<!-- Please do not remove the 'hadoop1' comment. See ./tools/generate_specific_pom.sh
-->
    +					<!--hadoop1 -->
    +					<name>!hadoop.profile</name>
    +				</property>
    +			</activation>
    +			<properties>
    +				<hbase.version>${hbase.hadoop1.version}</hbase.version>
    +			</properties>
    +		</profile>
    +		<profile>
    +			<id>hadoop-2</id>
    +			<activation>
    +				<property>
    +					<!-- Please do not remove the 'hadoop1' comment. See ./tools/generate_specific_pom.sh
-->
    +					<!--hadoop2 -->
    +					<name>hadoop.profile</name>
    +					<value>2</value>
    +				</property>
    +			</activation>
    +			<properties>
    +				<hbase.version>${hbase.hadoop2.version}</hbase.version>
    +			</properties>
    +			<dependencies>
    +				<!-- Force hadoop-common dependency -->
    +				<dependency>
    +					<groupId>org.apache.hadoop</groupId>
    +					<artifactId>hadoop-common</artifactId>
    +				</dependency>
    +			</dependencies>
    +		</profile>
    +		<profile>
    +			<id>cdh5.1.3</id>
    --- End diff --
    
    I think that's fine if you add a little comment explaining the variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message