flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-1223] Allow value escaping in...
Date Fri, 07 Nov 2014 10:34:31 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/187#discussion_r20003612
  
    --- Diff: flink-core/src/main/java/org/apache/flink/types/parser/StringParser.java ---
    @@ -30,7 +34,14 @@
     	private static final byte WHITESPACE_TAB = (byte) '\t';
     	
     	private static final byte QUOTE_DOUBLE = (byte) '"';
    -	
    +
    +	private static final Set<Byte> trailingCheckSet = Sets.newHashSet(
    --- End diff --
    
    The parsers are often stressed badly when reading large CSV files, so we think a lot about
performance here.
    
    I am wondering if a hash set is the best choice to check for these three elements. Computing
hash, table lookup, entry lookup, comparison, ...
    
    Might be cheaper to just hardwire the check for those types...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message