flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fpompermaier <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Upgraded APIs: Flink (0.8) and HBase...
Date Mon, 03 Nov 2014 13:46:00 GMT
Github user fpompermaier commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/172#discussion_r19732895
  
    --- Diff: flink-addons/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
    @@ -310,17 +264,13 @@ public void open(TableInputSplit split) throws IOException {
     
     	@Override
     	public TableInputSplit[] createInputSplits(final int minNumSplits) throws IOException
{
    +		HTable table = createTable(parameters);
     
    -		if (this.table == null) {
    -			throw new IOException("No table was provided.");
    -		}
    -
    -		final Pair<byte[][], byte[][]> keys = this.table.getStartEndKeys();
    -
    +		final Pair<byte[][], byte[][]> keys = table.getStartEndKeys();
     		if (keys == null || keys.getFirst() == null || keys.getFirst().length == 0) {
    -
     			throw new IOException("Expecting at least one region.");
     		}
    +		Scan scan = createScanner(parameters);
     		int count = 0;
     		final List<TableInputSplit> splits = new ArrayList<TableInputSplit>(keys.getFirst().length);
    --- End diff --
    
    Ok. done (in my local version)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message