flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Upgraded APIs: Flink (0.8) and HBase...
Date Mon, 03 Nov 2014 13:29:33 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/172#discussion_r19732203
  
    --- Diff: flink-addons/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
    @@ -108,14 +90,16 @@
     
     	protected HBaseResult hbaseResult;
     
    -	private org.apache.hadoop.conf.Configuration hConf;
    +	private Configuration parameters;
     
    +//	private org.apache.hadoop.conf.Configuration hConf;
    +	public TableInputFormat(Configuration parameters){
    +		this.parameters = parameters;
    +	}
    +	
     	@Override
     	public void configure(Configuration parameters) {
    -		HTable table = createTable(parameters);
    -		setTable(table);
    -		Scan scan = createScanner(parameters);
    -		setScan(scan);
    +		//TODO why parameters gets empty after execution??
    --- End diff --
    
    What exactly do you mean by first time and next times?
    ``configure()`` is invoked once in the JobManager to compute the input splits. Then the
class is serialized and shipped to all TaskManagers (TM). In each TM thread, the ``configure()``
method is called just once, before ``open()`` is called for each processed InputSplit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message