flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Upgraded APIs: Flink (0.8) and HBase...
Date Mon, 03 Nov 2014 11:52:44 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-addons/flink-hbase/src/main/java/org/apache/flink/addons/hbase/common/HBaseResult.java
    @@ -59,11 +64,18 @@ public String getStringData() {
     	public void read(DataInputView in) throws IOException {
    -		this.result.readFields(in);
    +		Deserializer<Result> deser = new ResultSerialization().getDeserializer(Result.class);
    +		deser.open(new DataInputViewStream(in));
    +		result = deser.deserialize(null);
    +		deser.close();
     	public void write(DataOutputView out) throws IOException {
    -		this.result.write(out);	
    +		Serializer<Result> ser = new ResultSerialization().getSerializer(Result.class);
    --- End diff --
    I hope you do not need the wrapper class anymore. As I said, the system should be able
to de/serialize any class. 
    If you change the bindings of the HBaseInputFormat from ``Record`` to ``Tuple2<ImmutableBytesWritable,
Result>`` then there is no need to wrap ``ImmutableBytesWritable`` and ``Result``

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message