flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Upgraded APIs: Flink (0.8) and HBase...
Date Mon, 03 Nov 2014 10:25:01 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/172#discussion_r19725771
  
    --- Diff: flink-addons/flink-hbase/src/main/java/org/apache/flink/addons/hbase/common/HBaseResult.java
---
    @@ -21,10 +21,15 @@
     
     import java.io.IOException;
     
    +import org.apache.flink.api.java.typeutils.runtime.DataInputViewStream;
     import org.apache.flink.core.memory.DataInputView;
     import org.apache.flink.core.memory.DataOutputView;
    +import org.apache.flink.core.memory.DataOutputViewStream;
     import org.apache.flink.types.Value;
     import org.apache.hadoop.hbase.client.Result;
    +import org.apache.hadoop.hbase.mapreduce.ResultSerialization;
    +import org.apache.hadoop.io.serializer.Deserializer;
    +import org.apache.hadoop.io.serializer.Serializer;
     
     public class HBaseResult implements Value {
    --- End diff --
    
    I think, we don't need the wrappers for HBaseResult and HBaseKey anymore.
    The new API allows to process arbitrary objects and serializes them with Avro (will be
changed to Kryo some time in the future). 
    But you should double check if this is working.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message