flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Upgraded APIs: Flink (0.8) and HBase...
Date Mon, 03 Nov 2014 10:19:46 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/172#discussion_r19725598
  
    --- Diff: flink-addons/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
    @@ -329,9 +279,9 @@ public void open(TableInputSplit split) throws IOException {
     				continue;
     			}
     
    -			final String regionLocation = this.table.getRegionLocation(keys.getFirst()[i], false).getHostnamePort();
    -			final byte[] startRow = this.scan.getStartRow();
    -			final byte[] stopRow = this.scan.getStopRow();
    +			final String regionLocation = table.getRegionLocation(keys.getFirst()[i], false).getHostnamePort();
    +			final byte[] startRow = scan.getStartRow();
    --- End diff --
    
    ``startRow`` and ``stopRow`` do not change in the loop right? 
    So these assignements could be moved outside of the loop?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message