flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Upgraded APIs: Flink (0.8) and HBase...
Date Mon, 03 Nov 2014 10:14:18 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/172#discussion_r19725351
  
    --- Diff: flink-addons/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
    @@ -108,14 +90,16 @@
     
     	protected HBaseResult hbaseResult;
     
    -	private org.apache.hadoop.conf.Configuration hConf;
    +	private Configuration parameters;
     
    +//	private org.apache.hadoop.conf.Configuration hConf;
    +	public TableInputFormat(Configuration parameters){
    +		this.parameters = parameters;
    +	}
    +	
     	@Override
     	public void configure(Configuration parameters) {
    -		HTable table = createTable(parameters);
    -		setTable(table);
    -		Scan scan = createScanner(parameters);
    -		setScan(scan);
    +		//TODO why parameters gets empty after execution??
    --- End diff --
    
    Why did you go for an empty ``configure()`` method? 
    Creating a table and a scanner does probably include communication with the HBase master,
which does not come for free. Depending on how expensive these operations are, it might make
sense to only do this once.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message