flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: Integration of Daniel's BLOB manager
Date Fri, 03 Oct 2014 15:57:35 GMT
Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/126#discussion_r18402807
  
    --- Diff: flink-addons/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/util/ClusterUtil.java
---
    @@ -37,18 +37,19 @@
     	 * 
     	 * @param jobGraph
     	 *            jobGraph
    -	 * @param numberOfTaskTrackers
    +	 * @param degreeOfPrallelism
     	 *            numberOfTaskTrackers
     	 * @param memorySize
     	 *            memorySize
     	 */
    -	public static void runOnMiniCluster(JobGraph jobGraph, int numberOfTaskTrackers, long
memorySize) throws Exception  {
    --- End diff --
    
    Is that really in the sense of what the streaming folks had in mind? Probably makes little
difference when everything is in the same JVM, but in general, I think such edits should not
be mixed into other pull requests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message